Add hint for unsample pixels #2069
Conversation
| @@ -51,6 +51,7 @@ namespace renderer | |||
| // PixelRendererBase class implementation. | |||
| // | |||
|
|
|||
| const uint8 NoSampleHint = 0; | |||
| const uint8 InvalidSampleHint = 1; | |||
| const uint8 CorrectSampleHint = 2; | |||
There was a problem hiding this comment.
Maybe it would be more logical that CorrectSampleHint is 0 and all problematic cases get non-zero values?
Also, can we find a better term than "hint"? These are not really hints, more like error codes...
There was a problem hiding this comment.
0 is because the tile is filled with 0 by default. This avoid to do extra process.
There was a problem hiding this comment.
Ok, makes sense.
The comment about "hint" stands though.
| @@ -116,6 +117,10 @@ void PixelRendererBase::on_tile_end( | |||
| tile.get_pixel(x, y, color); | |||
| color.rgb().set(0.2f * luminance(color.rgb())); // 20% of luminance | |||
| } | |||
| else if (sample_state[0] == NoSampleHint) | |||
There was a problem hiding this comment.
Simplify the logic, maybe with a switch where color gets assigned once in each case, instead of having a default value that later gets overwritten or altered.
|
Nice! |
oktomus
force-pushed
the
minor-aov-samples-feature
branch
from
bbe6b8b
to
537cffd
Compare
oktomus
force-pushed
the
minor-aov-samples-feature
branch
from
537cffd
to
702eea6
Compare
| @@ -51,8 +52,9 @@ namespace renderer | |||
| // PixelRendererBase class implementation. | |||
| // | |||
|
|
|||
| const uint8 InvalidSampleHint = 1; | |||
| const uint8 CorrectSampleHint = 2; | |||
| const uint8 NoState = 0; | |||
There was a problem hiding this comment.
NoState? Did you mean NoSample?
There was a problem hiding this comment.
The pixel can be both unsampled or unfinished. In my case, the pixel was sampled but pixel_end was never called.
Highlight in red unsampled areas
Pixels where
on_pixel_endwasn't called. Usefull when implementing a new renderer