Implement constructors for derived AABB class and fix gcc8 private delete member issue #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oktomus
commented
Jun 19, 2018
•
oktomus
commented
- gcc-8.1 type conversion error. #2093
- Build failed with gcc-8. #2052
dictoon
previously approved these changes
Jun 19, 2018
src/appleseed/foundation/math/aabb.h
Outdated
| // Value, vector and AABB types. | ||
| typedef T ValueType; | ||
| typedef Vector<T, N> VectorType; | ||
| typedef AABB<T, N> AABBType; | ||
|
|
||
| // Constructors. | ||
| #if !defined(_MSC_VER) || _MSC_VER >= 1800 | ||
| AABB() = default; // leave all components uninitialized |
There was a problem hiding this comment.
Align comments vertically (on a tab boundary).
dictoon
requested changes
Jun 19, 2018
GCC 8 forbids to inherit OIIO::TextureSystem if the delete method isn't oerriden.
With GCC 8, the keyword using is not working as expected and we need to implement all the constructors required in the derived class. Moreover, the keyword using is not available by default with VS2012. The constructor using the base class as a parameter is required to use all static members using or returning base class objects.
oktomus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.