Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stateful Tabs are broken #94

Closed
jondlm opened this issue Mar 10, 2016 · 3 comments
Closed

Stateful Tabs are broken #94

jondlm opened this issue Mar 10, 2016 · 3 comments
Labels
bug

Comments

@jondlm
Copy link
Contributor

jondlm commented Mar 10, 2016

The stateful Tabs aren't working. I have a hunch this might be related to #87.
@jondlm jondlm added the bug label Mar 10, 2016
@jondlm
Copy link
Contributor Author

jondlm commented Mar 11, 2016

Correction, they only don't work when you provide a selectedIndex or isSelected on a child. This is similar to the issue I was having with TextField but @ogupte fixed that issue. Need to investigate further.

@jondlm
Copy link
Contributor Author

jondlm commented Mar 15, 2016

Actually, looks like TextField isn't behaving as I'd expect either. The fix was a false positive I believe.

The problem is I want to set the value up front and let the component maintain its internal state until new props come in, but the current behavior is that props always beat out internal state, even on a re-render. Perhaps this could be a config option.

@jondlm
Copy link
Contributor Author

jondlm commented Mar 29, 2016

Will be fixed by #149

@jondlm jondlm closed this as completed Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jondlm