Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible signed_request signature validation error #38

Closed
dpogue opened this issue Aug 12, 2011 · 0 comments
Closed

Possible signed_request signature validation error #38

dpogue opened this issue Aug 12, 2011 · 0 comments

Comments

@dpogue
Copy link
Contributor

dpogue commented Aug 12, 2011

I was implementing my own signed_request system for a project, and came across an inconsistency in how MiniFB does signature validation.

https://github.com/appoxy/mini_fb/blob/master/lib/mini_fb.rb#L320
This uses the base64 of the payload to build the signature.

Facebook's PHP example and almost every other example in other languages that I've seen uses the url-encoded base64 of the payload.

This would only cause problems if the signature happened to contain the + / (or - _) characters, which doesn't seem to be very often. However I did encounter an instance in my application where the MiniFB code believed the signature to be invalid due to the url-encoded base64.

@treeder treeder closed this as completed Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants