Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 絵文字の作成者を取得するように修正 #699

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Conversation

MikuroXina
Copy link
Collaborator

Closes #689.

Type of Change:

コードの修正

Cause of the Problem (問題の原因)

Discord.js の API を再確認したところ emoji.fetchAuthor() が存在しており, プログラムの目的としてもこちらを使うのが正しいようでした.

Details of implementation (実施内容)

アダプタの実装は fetchAuthor() を利用するように修正し, あわせて interface EmojiDataemojiAuthorId の型を Snowflake にしておきました.

@MikuroXina MikuroXina requested a review from m1sk9 February 3, 2023 17:39
@MikuroXina MikuroXina self-assigned this Feb 3, 2023
@MikuroXina MikuroXina added the bug label Feb 3, 2023
@github-actions github-actions bot removed the bug label Feb 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Merging #699 (71c482f) into main (01bde80) will decrease coverage by 0.14%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
- Coverage   72.56%   72.43%   -0.14%     
==========================================
  Files          67       67              
  Lines        4691     4694       +3     
  Branches      443      443              
==========================================
- Hits         3404     3400       -4     
- Misses        847      854       +7     
  Partials      440      440              
Flag Coverage Δ
unittests 72.43% <33.33%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/adaptor/proxy/emoji.ts 57.14% <14.28%> (-0.76%) ⬇️
src/service/emoji-log.ts 56.66% <100.00%> (-19.20%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MikuroXina MikuroXina merged commit 800c6c1 into main Feb 3, 2023
@MikuroXina MikuroXina deleted the fix/#689 branch February 3, 2023 17:48
This was referenced Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

絵文字作成ログの作成者が正しく表示されない
3 participants