Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: クライアントユーザーのアクティビティ欄にバージョンを表示するように #752

Merged
merged 3 commits into from
Feb 26, 2023

Conversation

m1sk9
Copy link
Contributor

@m1sk9 m1sk9 commented Feb 25, 2023

Type of Change:

新機能, リファクタリング

Details of implementation (実施内容)

起動時と !version 実行時に表示されるビルドのバージョンをクライアントのアクティビティ欄にも表示するようにしました。

なお、取得に失敗した場合は表示しません。

CleanShot 2023-02-25 at 17 01 17@2x

また、軽微な変更として起動に表示されるログで各項目と値の意味が一致していなかったのでリファクタリングを行っています。

同時にトークンを除いた公開しても問題のない環境変数 (プレフィックス、チャンネルID、ギルドID) を表示するようにしました。これにより .env をわざわざ見なくても起動時に設定状況が見れるようになります。

CleanShot 2023-02-25 at 17 01 32@2x

@m1sk9 m1sk9 added C-enhancement Category: enhancement C-cleanup Category: cleanup within codebase labels Feb 25, 2023
@m1sk9 m1sk9 self-assigned this Feb 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Merging #752 (58e45ff) into main (261050f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #752   +/-   ##
=======================================
  Coverage   72.13%   72.13%           
=======================================
  Files          71       71           
  Lines        4758     4758           
  Branches      466      466           
=======================================
  Hits         3432     3432           
  Misses        861      861           
  Partials      465      465           
Flag Coverage Δ
unittests 72.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@m1sk9 m1sk9 merged commit b74c595 into main Feb 26, 2023
@m1sk9 m1sk9 deleted the feat/activity-status branch February 26, 2023 06:10
This was referenced Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: cleanup within codebase C-enhancement Category: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants