Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil pointer exception #361

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Fix nil pointer exception #361

merged 1 commit into from
Jul 18, 2019

Conversation

tamalsaha
Copy link
Contributor

@tamalsaha tamalsaha merged commit 25795cb into master Jul 18, 2019
@tamalsaha tamalsaha deleted the x7 branch July 18, 2019 00:38
@scottrigby
Copy link

@tamalsaha is this planned to be part of an upcoming release?

@tamalsaha
Copy link
Contributor Author

Yes. I looking to cut a release in a 1-2 weeks.

@mbelang
Copy link

mbelang commented Aug 22, 2019

@tamalsaha when is this getting release? Thanks

@scottrigby
Copy link

Left feedback on #363, but can that be a follow-up to a new release that contains this fix?

@mbelang
Copy link

mbelang commented Sep 3, 2019

Is the memory problem fixed by this? If so would like to have a release of this please. Thx

@scottrigby
Copy link

@mbelang I haven't done this yet, but good feedback may be to build the app/image with this fix in place, deploy it and see if it fixes the issue?

@tamalsaha
Copy link
Contributor Author

I have released v0.11.0 https://github.com/appscode/kubed/releases/tag/v0.11.0 . Please give it a shot.

@mbelang
Copy link

mbelang commented Sep 10, 2019

I'm testing it at the moment. I monitor for memory increase.

Out of curiosity, how much resources you recommend?
I currently set for limits and resources:

cpu:     150m
memory:  128Mi

@tamalsaha
Copy link
Contributor Author

What you have set should be enough.

@mbelang
Copy link

mbelang commented Sep 11, 2019

So far it restarted twice because of oom killed. So I suspect that the leak is still present. The only feature I use is the config map sync.

@tamalsaha
Copy link
Contributor Author

Are you seeing any logs like https://github.com/appscode/kubed/issues/304#issuecomment-508024105 ?

@mbelang
Copy link

mbelang commented Sep 11, 2019

The only error log I see from kubed is:
Skipping failed API Groups: unable to retrieve the complete list of server APIs: kubed.appscode.com/v1alpha1: the server is currently unable to handle the request

It restarted 9 times since I updated it to 0.11 and the pattern is consistent. In the picture below, you will see where I updated to 0.11.

kubed-memory-requests

@tamalsaha
Copy link
Contributor Author

Could you increase the memory to say 512MiB ? And then see if the pattern continues.

@mbelang
Copy link

mbelang commented Sep 12, 2019

Keeps increasing and reaching the limits. It's just takes longer as you can figure :)

@tamalsaha
Copy link
Contributor Author

tamalsaha commented Sep 12, 2019

If it is possible, can you please email be the config file you are using? My email us tamal AT appscode.com .

@mbelang
Copy link

mbelang commented Sep 13, 2019

Sent @tamalsaha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants