-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nil pointer exception #361
Conversation
xref: https://github.com/appscode/kubed/issues/304#issuecomment-508024105 Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha is this planned to be part of an upcoming release? |
Yes. I looking to cut a release in a 1-2 weeks. |
@tamalsaha when is this getting release? Thanks |
Left feedback on #363, but can that be a follow-up to a new release that contains this fix? |
Is the memory problem fixed by this? If so would like to have a release of this please. Thx |
@mbelang I haven't done this yet, but good feedback may be to build the app/image with this fix in place, deploy it and see if it fixes the issue? |
I have released v0.11.0 https://github.com/appscode/kubed/releases/tag/v0.11.0 . Please give it a shot. |
I'm testing it at the moment. I monitor for memory increase. Out of curiosity, how much resources you recommend?
|
What you have set should be enough. |
So far it restarted twice because of oom killed. So I suspect that the leak is still present. The only feature I use is the config map sync. |
Are you seeing any logs like https://github.com/appscode/kubed/issues/304#issuecomment-508024105 ? |
The only error log I see from kubed is: It restarted 9 times since I updated it to 0.11 and the pattern is consistent. In the picture below, you will see where I updated to 0.11. |
Could you increase the memory to say 512MiB ? And then see if the pattern continues. |
Keeps increasing and reaching the limits. It's just takes longer as you can figure :) |
If it is possible, can you please email be the config file you are using? My email us |
Sent @tamalsaha. |
xref: https://github.com/appscode/kubed/issues/304#issuecomment-508024105
Signed-off-by: Tamal Saha tamal@appscode.com