John/update monthly task #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `figures.log.log_exec_time` as a context manager to output the log time for a block of code executed within. The purpose of this is as a convenience to logging execution time. At this time, it does not handle variables within the block so it only outputs the label passed in as a parameter
Added guidance in this module
Broken dependencies found after creating new virtualenvs
We found that figures breaks in Ginkgo due to an apparent issue that Django 1.8 does not support datetime `__day__lte` query parameter. Pending a decision on whether we need to continue to support Ginkgo, we are disabling these tests in Ginkgo so that Tox will pass. If we do need to continue Ginkgo support, then we will implement a compatibility fix. Otherwise, we will remove all Ginkgo support in an upcoming release
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
+ Coverage 91.50% 91.62% +0.11%
==========================================
Files 40 41 +1
Lines 2061 2078 +17
==========================================
+ Hits 1886 1904 +18
+ Misses 175 174 -1
Continue to review full report at Codecov.
|
edx-lint 0.5.5 requires pylint 1.7.1. Not sure why this error is happening now, since we've edx-lint 0.5.5 and pylint 1.9.5 have been coexisting in Figures for a while
johnbaldwin
force-pushed
the
john/update-monthly-task
branch
from
13ba471
to
ba65b65
Compare
It was previously set to not run by default. Since the monthly task is part of Figures normal workflow, we want it enabled by default. This can be overridden by setting the ENV_VARS 'FIGURES' variable `ENABLE_FIGURES_MONTHLY_METRICS` to False in the lms.env.json file
melvinsoft
approved these changes
Aug 11, 2020
|
@johnbaldwin I did a light review, all changes makes sense to me. Since Omar is on vacation, I'd say let's merge it and test on Staging and let's ping Omar when is back from vacation for a more detailed review, and we can address changes in a follow up PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely cause is that I had the default settings to
Falseto run the monthly metrics job (yeah, that's on me). This should be on by default since the monthly job is part of Figures standard workflowAlso added a log timing instrumentation context manager and fixed package dependency versions.
Found an incompatibility with Ginkgo in
figures.mau. There is a query that is not compatible with Django 1.8So for now, disabled failing Ginkgo tests. Then assess the fix and need