Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

John/update monthly task #242

Merged
merged 7 commits into from Aug 11, 2020
Merged

John/update monthly task #242

merged 7 commits into from Aug 11, 2020

Commits on Aug 10, 2020

  1. Added execution time context manager logger

    Added `figures.log.log_exec_time` as a context manager to output the log
    time for a block of code executed within.
    
    The purpose of this is as a convenience to logging execution time. At
    this time, it does not handle variables within the block so it only
    outputs the label passed in as a parameter
    johnbaldwin committed Aug 10, 2020
    Copy the full SHA
    07945aa View commit details
    Browse the repository at this point in the history
  2. Update docstrings in figures.helpers

    Added guidance in this module
    johnbaldwin committed Aug 10, 2020
    Copy the full SHA
    751e3aa View commit details
    Browse the repository at this point in the history
  3. Updated requirements files to fix dependencies

    Broken dependencies found after creating new virtualenvs
    johnbaldwin committed Aug 10, 2020
    Copy the full SHA
    35c8894 View commit details
    Browse the repository at this point in the history
  4. Disabled Ginkgo tests that touch the MAU 1G performance fix

    We found that figures breaks in Ginkgo due to an apparent issue that Django 1.8 does not support datetime `__day__lte` query parameter.
    
    Pending a decision on whether we need to continue to support Ginkgo, we
    are disabling these tests in Ginkgo so that Tox will pass.
    
    If we do need to continue Ginkgo support, then we will implement a
    compatibility fix. Otherwise, we will remove all Ginkgo support in an
    upcoming release
    johnbaldwin committed Aug 10, 2020
    Copy the full SHA
    436c5cf View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Pylint fix figures after reverting to pylint 1.7.1

    edx-lint 0.5.5 requires pylint 1.7.1. Not sure why this error is
    happening now, since we've edx-lint 0.5.5 and pylint 1.9.5 have been
    coexisting in Figures for a while
    johnbaldwin committed Aug 11, 2020
    Copy the full SHA
    ba65b65 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    4fc61e9 View commit details
    Browse the repository at this point in the history
  3. Set monthly task to run by default

    It was previously set to not run by default. Since the monthly task is
    part of Figures normal workflow, we want it enabled by default. This can
    be overridden by setting the ENV_VARS 'FIGURES' variable
    `ENABLE_FIGURES_MONTHLY_METRICS` to False in the lms.env.json file
    johnbaldwin committed Aug 11, 2020
    Copy the full SHA
    4a27cb9 View commit details
    Browse the repository at this point in the history