Fixes to Learner Progress Overview #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 41 41
Lines 2134 2134
=======================================
Hits 1964 1964
Misses 170 170 Continue to review full report at Codecov.
|
OmarIthawi
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
Fun fact: LGTM.com is an company site that advocates against "LGTM" with a 21 million dollar investment.
But hey, LGTM 😁
| @@ -196,7 +196,14 @@ class ProgressOverview extends Component { | |||
| coursesFilter.forEach((course, i) => { | |||
| const userProgress = userCoursesImmutable.find(singleCourse => singleCourse.get('course_id') === course.id); | |||
| if (userProgress) { | |||
| singleRecord[course.id] = `Progress: ${userProgress.getIn(['progress_percent'])}/1 | Sections: ${userProgress.getIn(['progress_details', 'sections_worked'])}/${userProgress.getIn(['progress_details', 'sections_possible'])} | Points: ${userProgress.getIn(['progress_details', 'points_earned'])}/${userProgress.getIn(['progress_details', 'points_possible'])}`; | |||
|
|
|||
| const progressPercent = (userProgress.getIn(['progress_percent'])) ? userProgress.getIn(['progress_percent']).toFixed(2) : '-'; | |||
There was a problem hiding this comment.
This could be a helper function, but okay for now.
There was a problem hiding this comment.
Yup, agreed. However this whole view is done for now in a kind of anti-pattern approach. It is a monolith, and should be refactored down the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a list of items fixed:
If you select a course, you can’t add another course with the same name to the dashboard
Now you can and you can easily distinguish them because:
Data is shown to a needless level of specificity, causing fields to overflow
Fixed. Literally
Data that is 0 is invisible, just leaving slashes
This is now fixed - checks added into code.
The page looks weird when you only have one course selected
Not anymore! Now introducing - “wide view toggle”. Initially you have regular screen width. If you need more, you can toggle it.
Loading all courses initially in LPV is useless
New behaviour:
Add more info to multicourse select dropdown to distinguish reruns
Done.
Enable course multiselector search by course number
Done.