Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Incorrect transient widget name state #33386

Closed
1 task
Tracked by #33138
riodeuno opened this issue May 13, 2024 · 0 comments · Fixed by #33672
Closed
1 task
Tracked by #33138

[Bug]: Incorrect transient widget name state #33386

riodeuno opened this issue May 13, 2024 · 0 comments · Fixed by #33672
Assignees
@riodeuno
Labels
Anvil Pod Issue related to Anvil project Anvil team issues related to the new layout system anvil High This issue blocks a user from building or impacts a lot of users Task A simple Todo

Comments

@riodeuno
Copy link
Contributor

riodeuno commented May 13, 2024 •
edited
Loading

while scrolling widget name shows different states like selected state even if it is not selected.
https://www.loom.com/share/44efa67b6c664f5a9584c1638b7af149?sid=8b635fd0-c63a-413d-8eb0-29935f183a66
@riodeuno riodeuno mentioned this issue May 13, 2024
Open
10 tasks
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label May 13, 2024
@riodeuno riodeuno changed the title while scrolling widget name shows different states like selected state even if it is not selected. https://www.loom.com/share/44efa67b6c664f5a9584c1638b7af149?sid=8b635fd0-c63a-413d-8eb0-29935f183a66 [Bug]: Incorrect transient widget name state May 13, 2024
@riodeuno riodeuno self-assigned this May 13, 2024
@riodeuno riodeuno added Anvil Pod Issue related to Anvil project Anvil team issues related to the new layout system anvil labels May 13, 2024
@ramsaptami ramsaptami added the High This issue blocks a user from building or impacts a lot of users label May 15, 2024
@riodeuno riodeuno mentioned this issue May 23, 2024
Merged
2 tasks
riodeuno added a commit that referenced this issue May 23, 2024
@riodeuno
perf: Anvil widget name component rendering (#33672)
e0df8f7 
## Description
- Fixes some of the performance issues in the widget name component for
Anvil. Particularly, the following
- All widget name components for all widgets used to be added to the DOM
tree, even if they're not visible
- All widget name components had the floating-ui listeners added to them
at all times, leading to a sharp rise in the number of JS listeners and
increasing RAM usage.
- Widget name component positions used to recompute sporadically,
leading to perceived jitter when users scrolled too quickly.

The above issues have been fixed by the following changes
- Widget name component gets added to the DOM only when
`nameComponentState !== "none"`
- Widget name component only has listeners added by floating-ui when the
name component needs to be visible
- Floating-ui is configured to recompute in all `requestAnimationFrame`
cycles


Fixes #33386
Fixes #33330 

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9205700153>
> Commit: db2487d
> Cypress dashboard: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9205700153&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank"> Click here!</a>
> The following are new failures, please fix them before merging the PR:
<ol>
> <li>cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts </ol>
> To know the list of identified flaky tests - <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">Refer here</a>

<!-- end of auto-generated comment: Cypress test results  -->





## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riodeuno riodeuno

Labels
Anvil Pod Issue related to Anvil project Anvil team issues related to the new layout system anvil High This issue blocks a user from building or impacts a lot of users Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: Anvil widget name component rendering appsmithorg/appsmith
3 participants
@riodeuno @Nikhil-Nandagopal @ramsaptami