-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Anvil widget name component rendering #33672
Conversation
- Add a ghost component that prevents the widget underneath the widget name component from being focused - Select widget when dragging a focused widget from the widget name component - Adjust offsets and sizes of the ghost component and the widget name button - Remove onMouseLeave events from widgets and add an onMouseLeave event to the Canvas.
## Description - If the parent is already selected, disable parent selection - Introduce the selector to check if parent is selected. Fixes #33648 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No
…thub.com/appsmithorg/appsmith into feat/drag-widget-name-component-on-hover
- Ask floating UI to recompute more frequently to make sure the widget and widget name component don't stray away when users interact quickly - Add a widget name component to the DOM tree only if they're supposed to be visible
WalkthroughWalkthroughThe changes improve the positioning, visibility, and behavior of the Changes
Assessment against linked issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9201992055. |
Deploy-Preview-URL: https://ce-33672.dp.appsmith.com |
…o perf/anvil-widget-name-component-rendering
/build-deploy-preview skip-tests=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one question. Why are we changing the id?
2024-05-23.12.32.56.mov
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9205699384. |
@KelvinOm Nice observation. Not sure what is happening. Floating-ui is creating these and I believe this is because |
Deploy-Preview-URL: https://ce-33672.dp.appsmith.com |
Description
The above issues have been fixed by the following changes
nameComponentState !== "none"
requestAnimationFrame
cyclesFixes #33386
Fixes #33330
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Caution
🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9205700153
Commit: db2487d
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
Communication
Should the DevRel and Marketing teams inform users about this change?