Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Only catch feature flagging related exceptions in the aspect #33634

Open
nidhi-nair opened this issue May 22, 2024 · 0 comments
Open

[Task]: Only catch feature flagging related exceptions in the aspect #33634

nidhi-nair opened this issue May 22, 2024 · 0 comments
Labels
Backend This marks the issue or pull request to reference server code Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers Feature Flagging Anything related feature flagging Low effort Takes 1-2 days Low An issue that is neither critical nor breaks a user flow Production Task A simple Todo

Comments

@nidhi-nair
Copy link
Contributor

SubTasks

Currently any exception in a method that's feature flagged is caught by the aspect that has passed control to that method, and subsequently converted into a feature flagging related error. We want such captures to be limited to only feature flagging related errors (no super class, incorrect method definition, no super method, etc.). Every other throwable thrown by the "invoked" method should be passed along as is.
@nidhi-nair nidhi-nair added Backend This marks the issue or pull request to reference server code Low An issue that is neither critical nor breaks a user flow Production Low effort Takes 1-2 days Task A simple Todo Feature Flagging Anything related feature flagging labels May 22, 2024
@github-actions github-actions bot added the Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers label May 22, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Platform Administration Pod Issues related to platform administration & management and removed Platform Administration Pod Issues related to platform administration & management labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backend This marks the issue or pull request to reference server code Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers Feature Flagging Anything related feature flagging Low effort Takes 1-2 days Low An issue that is neither critical nor breaks a user flow Production Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nikhil-Nandagopal @nidhi-nair