-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign for Docs pages #377
Comments
I like the ability to close the side TOC to create more space for the docs. It looks more intuitive to close than to reopen though .... some sort of chevron/tab half way up when it is closed might be something to try? I like the pink highlighting in all but the inline code snippets, which seem to stand out too much. Perhaps a lighter shade of pink? Overall, much better than we have today. Good stuff! |
Just a few things I've picked up on:
Overall though, it is a massive improvement on what's currently there so a great job on this @KyeMaloy97 🎉 |
Here is an example with a grey background matching the code blocks, for the inline code snippets. As for the icon for copy and paste, mine was a quick example, and I don't mind using a different one to match what we are going to use on the Stacks cards. The icons for the sidebar opening and closing were probably the most fiddly bit as there is no convention for icons, gatsby has one, react has another, etc etc. Would love to get some feedback on what people make of the icons and whether they understand what they do. |
Hi as I'm currently going through the stacks documents on the website, restructuring etc. I can leave feedback on potential design changes. @helenmasters pointed me towards this issue as I thought I preferred the code blocks similar to the ones @ddunn2 implemented on the Kitura website. Coming here the changes look very good so far! ...While I'm here, the mobile sidebar icon isn't immediately obvious to me what it does, I feel like 3 horizontal lines when it isn't displayed and then just an X when to is displayed would suffice. But I've heard that some people have distain towards the classic burger menu icons. |
Closing this issue as development work as begun based on the last screenshot here. |
Summary
At the moment, the documentation for Appsody uses a fairly basic styling, which could do with some prettying up, as well as improving legibility and how code snippets appear/function.
Here are some initial screenshots of a potential design for the new collapsible sidebar and content of a doc. Feel free to leave comments or suggestions though on the design!
Mockups
The text was updated successfully, but these errors were encountered: