Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign for Docs pages #377

Closed
KyeMaloy97 opened this issue Nov 13, 2019 · 12 comments
Closed

Redesign for Docs pages #377

KyeMaloy97 opened this issue Nov 13, 2019 · 12 comments
Assignees
Labels
webdev Improvements or additions to the website

Comments

@KyeMaloy97
Copy link
Contributor

KyeMaloy97 commented Nov 13, 2019

Summary

At the moment, the documentation for Appsody uses a fairly basic styling, which could do with some prettying up, as well as improving legibility and how code snippets appear/function.

Here are some initial screenshots of a potential design for the new collapsible sidebar and content of a doc. Feel free to leave comments or suggestions though on the design!

Mockups

Screenshot 2019-11-13 at 13 41 36
Screenshot 2019-11-13 at 13 41 16

@SueChaplain
Copy link
Contributor

I like the ability to close the side TOC to create more space for the docs. It looks more intuitive to close than to reopen though .... some sort of chevron/tab half way up when it is closed might be something to try?

I like the pink highlighting in all but the inline code snippets, which seem to stand out too much. Perhaps a lighter shade of pink?

Overall, much better than we have today. Good stuff!

@DunnCoding DunnCoding added the webdev Improvements or additions to the website label Nov 13, 2019
@KyeMaloy97
Copy link
Contributor Author

Here is a tweak I have made to make the pink for the inline code less in-your-face, and also I have moved the tab for opening the sidebar up the page to make it more prominent :)

Screenshot 2019-11-13 at 14 53 49

@KyeMaloy97
Copy link
Contributor Author

KyeMaloy97 commented Nov 13, 2019

Also, here are some examples of the design on an iPhone X and SE sized display.

Screenshot 2019-11-13 at 15 24 32

@KyeMaloy97
Copy link
Contributor Author

Updated some of the icons, added a light tint to the code blocks background and shuffled some elements around. Also shows the footer in one of the mockups.

Screenshot 2019-11-13 at 16 22 12

@KyeMaloy97
Copy link
Contributor Author

Made some more minor tweaks to the design

Screenshot 2019-11-15 at 10 17 07

@KyeMaloy97
Copy link
Contributor Author

KyeMaloy97 commented Nov 15, 2019

Spoke with Melissa, and she made some suggestions on toning down all the pink and shifting caret positions in the sidebar

Screenshot 2019-11-15 at 15 16 30

@DunnCoding
Copy link
Contributor

Just a few things I've picked up on:

  • The copy icon you're using for copying code is different to the one we're currently use for the stack cards on the homepage. We should ensure that the icons we use for copying are consistent as I do believe the new stacks design also uses a different icon to the others we have.
  • I feel the pink background you're using for inline code snippets draws the eye more then other elements on the page, it seems more evident now that you've toned the pink down. I'd suggest trying the grey colour you're using for the code blocks, and see how that looks.
  • The sidebar closing/opening icon, we need to make sure people know what that icon means in the context you're using it as it's not the typical icon to use especially on mobile where there is no helper text. It makes sense to me, but then I know what it's supposed to do. So it'd be useful to get peoples opinion on it.

Overall though, it is a massive improvement on what's currently there so a great job on this @KyeMaloy97 🎉

@KyeMaloy97
Copy link
Contributor Author

Here is an example with a grey background matching the code blocks, for the inline code snippets.

Screenshot 2019-11-18 at 09 49 59

As for the icon for copy and paste, mine was a quick example, and I don't mind using a different one to match what we are going to use on the Stacks cards. The icons for the sidebar opening and closing were probably the most fiddly bit as there is no convention for icons, gatsby has one, react has another, etc etc.

Would love to get some feedback on what people make of the icons and whether they understand what they do.

@CameronMcWilliam
Copy link
Collaborator

Hi as I'm currently going through the stacks documents on the website, restructuring etc. I can leave feedback on potential design changes. @helenmasters pointed me towards this issue as I thought I preferred the code blocks similar to the ones @ddunn2 implemented on the Kitura website. Coming here the changes look very good so far!

...While I'm here, the mobile sidebar icon isn't immediately obvious to me what it does, I feel like 3 horizontal lines when it isn't displayed and then just an X when to is displayed would suffice. But I've heard that some people have distain towards the classic burger menu icons.

@KyeMaloy97
Copy link
Contributor Author

I have changed the icons to better suit the conventions users expect. I also have added a mockup with a longer sidebar to show how the sidebar would handle that (when we have lots of topics in it)

Screenshot 2019-11-18 at 13 55 02

@KyeMaloy97
Copy link
Contributor Author

Perhaps the final design before we go ahead and start splitting the work up and implementing these changes...

Screenshot 2019-11-19 at 14 36 34

@DunnCoding
Copy link
Contributor

Closing this issue as development work as begun based on the last screenshot here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webdev Improvements or additions to the website
Projects
None yet
Development

No branches or pull requests

4 participants