Pass user env/flag binds into container as SINGULARITY_BIND #5670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #5599 In prior versions of singularity the `SINGULARITY_BIND` env var would pass into the container. I've seen `SINGULARITY_BIND` examined in containers to e.g. checkthat a user specifically bound in a data directory where that's necessary. Restore so that `SINGULARITY_BIND` in the conatiner reflects user defined env var and flag binds.
dtrudg
changed the title
This was referenced Nov 11, 2020
This was referenced Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
In prior versions of singularity the
SINGULARITY_BINDenv var wouldpass into the container. I've seen
SINGULARITY_BINDexamined incontainers to e.g. check that a user specifically bound in a data
directory where that's necessary.
Restore so that
SINGULARITY_BINDin the container reflects userdefined env var, and also now flag binds.
Checking
SINGULARITY_BINDin a container like this is admittedly fragile - but this PR is concerned with allowing it, as it has been requested in #5599This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make testallAttn: @singularity-maintainers