Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash while using Apptentive library via Cocoapods #79

Closed
gagarwal opened this issue Feb 20, 2014 · 2 comments
Closed

Crash while using Apptentive library via Cocoapods #79

gagarwal opened this issue Feb 20, 2014 · 2 comments

Comments

@gagarwal
Copy link

I am using Apptentive version v1.2.6 and getting following crash:

*** Assertion failure in -[ATEvent apiJSON], /Users/pkamb/Desktop/Apptentive Code/apptentive-ios/ApptentiveConnect/source/Model/ATEvent.m:52

This is a NSAssert failure. I just cloned the Apptentive code from GitHub repository (https://github.com/apptentive/apptentive-ios.git) and found that in v1.2.7 the code at ATEvent.m:52 is changed to have "ATLogError" instead of NSAssert(s).

But still there are lot of NSAssert(s) in Apptentive code base. The library that I am getting through Cocoapods is having NSAssert(s) ENABLED. It should be release library with "NS_BLOCK_ASSERTIONS" Preprocessor Macros flag set. Setting this flag will DISABLE NSAssert(s) in the release version of library, and thus when others integrate this library in their projects, application will not crash.

This seems like a blocking issue for me, as I cannot release my application with NSAssert(s) enabled.

Let me know if you need more information. You can reach me at:
gaurav.agarwal@inrix.com

Regards
Gaurav Agarwal

@pkamb
Copy link
Contributor

pkamb commented Feb 20, 2014

Thanks for the report. The specific assert here was removed in 1.2.7, which should fix the immediate issue. I will also apply NS_BLOCK_ASSERTIONS to the static library build for the next release.

@pkamb pkamb closed this as completed in 3b62f06 Feb 21, 2014
@pkamb
Copy link
Contributor

pkamb commented Feb 21, 2014

Fixed in v1.2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants