Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate favicon Route if a custom logo is configured #34

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Generate favicon Route if a custom logo is configured #34

merged 2 commits into from
Jun 13, 2022

Commits on Jun 10, 2022

  1. Add missing custom-logo golden test

    @simu
    simu committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    77c743a View commit details
    Browse the repository at this point in the history

  2. Generate favicon Route if a custom logo is configured 

    When the OCP console is customized, the default favicon is not served,
which is an intentional design decision, as documented in
https://bugzilla.redhat.com/show_bug.cgi?id=1844883#c1.

However, that bugzilla provides a workaround to restore the default
favicon when the console is customized, cf.
https://bugzilla.redhat.com/show_bug.cgi?id=1844883#c3.

We implement this workaround in this commit if the console logo is
customized, and a custom hostname is configured, as we otherwise can't
configure `spec.hostname` for the additional route.

Ideally, we'd like to allow users to configure a custom favicon if
they're customizing the logo, but that's currently not possible.

Fixes #27
    @simu
    simu committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    4862292 View commit details
    Browse the repository at this point in the history