Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store User Data ina DB #6

Open
GiovanniSmokes opened this issue Aug 22, 2023 · 2 comments · May be fixed by #52
Open

Store User Data ina DB #6

GiovanniSmokes opened this issue Aug 22, 2023 · 2 comments · May be fixed by #52

Comments

@GiovanniSmokes
Copy link
Contributor

GiovanniSmokes commented Aug 22, 2023

Currently users are stored in the file system. We should persist users in the DB

@GiovanniSmokes GiovanniSmokes changed the title To-Do: Store User Data ina DB Store User Data ina DB Aug 27, 2023
@vporton
Copy link
Contributor

vporton commented Oct 10, 2023

Doing this in a clean way requires changing chat_messages table to refer to a user by numeric ID rather than by user_id (email). Therefore we need database migrations

We need to choose which DB toolkit we will use for migrations:

BTW, how much decision power will you allocate to me? Can I solve questions like this one by myself? You, at least, should advise me on whether to use SQLAlchemy or an alternative.

@apssouza22
Copy link
Owner

@vporton I would not bother with migration, you can just change the table. I am fine adding it though. SQLALchemy is the one I was using in my previous job. It is good enough. 👍

@vporton vporton linked a pull request Oct 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants