Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all DB APIs return proper error message when the content requested is out of the pruner window. #217

Closed
msmouse opened this issue Mar 16, 2022 · 2 comments
Assignees

Comments

@msmouse
Copy link
Contributor

msmouse commented Mar 16, 2022

This is part of #103

  1. Whenever possible, our error message should indicate that content is pruned.
  2. When not possible (get_txn_by_hash), return None
  3. APIs shouldn't panic on out-of-window queries
  4. would be nice if we convert the DB interface to return AptDbError, so the tests can assert by error types. We can do something like impl From<anyhow::Error> for AptDbError and a AptDbError::Misc(anyhow::Error) so that not much needs to change.
@gregnazario
Copy link
Contributor

Has this been cleaned up?

@msmouse msmouse closed this as completed Aug 29, 2022
@msmouse
Copy link
Contributor Author

msmouse commented Aug 29, 2022

I think we are in good shape with all the checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants