Skip to content
This repository has been archived by the owner on Oct 18, 2021. It is now read-only.

DB Query to Model Eloquent #38

Closed
InspectorGadget opened this issue Oct 23, 2019 · 4 comments · Fixed by #40
Closed

DB Query to Model Eloquent #38

InspectorGadget opened this issue Oct 23, 2019 · 4 comments · Fixed by #40
Assignees
@InspectorGadget
Labels
enhancement New feature or request

Comments

@InspectorGadget
Copy link
Member

InspectorGadget commented Oct 23, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Move direct Query to their Models for performance and organisation

Describe alternatives you've considered
None

Additional context
Not applicable
@InspectorGadget InspectorGadget added the enhancement New feature or request label Oct 23, 2019
@InspectorGadget InspectorGadget self-assigned this Oct 23, 2019
@kklee998
Copy link

Why is this needed tho? some context please?

@InspectorGadget
Copy link
Member Author

To prevent injection

@InspectorGadget
Copy link
Member Author

and tidy basically/laravel standards

@InspectorGadget
Copy link
Member Author

@kklee998 Close this when you are committing your Model fix

@kklee998 kklee998 mentioned this issue Oct 26, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@InspectorGadget InspectorGadget

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Meetup attendees apusds/cms
2 participants
@InspectorGadget @kklee998