Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy version requirement #24

Closed
thomasdkelly opened this issue Jan 17, 2022 · 3 comments
Closed

numpy version requirement #24

thomasdkelly opened this issue Jan 17, 2022 · 3 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@thomasdkelly
Copy link
Collaborator

A recent merge changed the numpy requirement to numpy>=1.21.

As of wiriting the current version is 1.22.1 so our requirement is quite stringent. Not sure if this is completely necessary.

numpy=1.21 also requires python=3.8 so this has caused me an error when trying to run setup.py within aquacrop.

@thomasdkelly thomasdkelly added the dependencies Pull requests that update a dependency file label Jan 20, 2022
@arongergely
Copy link
Contributor

arongergely commented Feb 2, 2022

When installing locally in development mode via pip install -e . , it picks this up so I get:

ERROR: numba 0.55.0 has requirement numpy<1.22,>=1.18, but you'll have numpy 1.22.1 which is incompatible.

The model won't run for the same reason.
For numba 0.55 the max numpy version is 1.22.0:

https://github.com/numba/numba/blob/release0.55/setup.py#L26

There are some minimum requirements as well (numpy 1.18, python 3.7)

Opened PR with a fix: #34

@arongergely
Copy link
Contributor

About python 3.7 being a minimum requirement, that may be a bit steep as well? Not sure if we can do anything about it, other than looking at different numba versions maybe

@thomasdkelly
Copy link
Collaborator Author

#34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants