Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: critial is a typo #1117

Merged
merged 2 commits into from Apr 8, 2022
Merged

Conversation

yurrriq
Copy link
Contributor

@yurrriq yurrriq commented Apr 7, 2022

Description

Critical is spelled incorrectly in a number of places.

grep -ril critial |
    xargs sed -i \
        -e 's/CRITIAL/CRITICAL/g' \
        -e 's/Critial/Critical/g' \
        -e 's/critial/critical/g'

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

    grep -ril critial |
        xargs sed -i \
            -e 's/CRITIAL/CRITICAL/g' \
            -e 's/Critial/Critical/g' \
            -e 's/critial/critical/g'
@yurrriq yurrriq marked this pull request as ready for review April 7, 2022 21:37
@danielpacak danielpacak self-requested a review April 7, 2022 21:41
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1117 (27d91ae) into main (369589a) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1117      +/-   ##
==========================================
- Coverage   58.00%   57.96%   -0.05%     
==========================================
  Files          71       71              
  Lines        9290     9290              
==========================================
- Hits         5389     5385       -4     
- Misses       3354     3357       +3     
- Partials      547      548       +1     
Impacted Files Coverage Δ
pkg/operator/controller/ciskubebenchreport.go 52.98% <0.00%> (-1.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 369589a...27d91ae. Read the comment docs.

@danielpacak danielpacak added this to the Release v0.15.3 milestone Apr 8, 2022
Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @yurrriq Thank you for the fix!

@danielpacak danielpacak merged commit 8995fb7 into aquasecurity:main Apr 8, 2022
@yurrriq yurrriq deleted the critical-typo-fix branch April 8, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants