feat: update severity enum in config audit check #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #992 +/- ##
==========================================
+ Coverage 62.44% 62.65% +0.20%
==========================================
Files 59 59
Lines 7325 7328 +3
==========================================
+ Hits 4574 4591 +17
+ Misses 2290 2275 -15
- Partials 461 462 +1
Continue to review full report at Codecov.
|
chen-keinan
reviewed
Mar 2, 2022
chen-keinan
reviewed
Mar 2, 2022
The ConfigAuditReport used danger and warning enums to describe severity of audit checks. These enum values where inherited from Polaris data model. This patch updates severities to CRITICAL, HIGH, MEDIUM, and LOW. Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
chen-keinan
approved these changes
Mar 2, 2022
|
Critical is spelled incorrectly here. See also #1117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConfigAuditReport used danger and warning enums to describe
severity of audit checks. These enum values where inherited from
Polaris data model. This patch updates severities to CRITICAL,
HIGH, MEDIUM, and LOW.
Signed-off-by: Daniel Pacak pacak.daniel@gmail.com