feat(trivy): add mirror config in helm chart #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the trivy mirror configuration to the starboard operator helm chart. This particular implementation is made to match the definitions from the documentation and therefore uses two layers for the object and singular terminology. The patch is required because currently there is no way than post deployment patching of the configmap in order to utilise this feature, which works against the intention of helm. It was also very confusing to find the documentation providing this option, but the helm chart not doing so, therefore this patch should help to cleanup potential confusion. References: https://aquasecurity.github.io/starboard/v0.15.4/vulnerability-scanning/trivy/#settings
|
|
Codecov Report
@@ Coverage Diff @@
## main #1159 +/- ##
==========================================
+ Coverage 58.09% 58.15% +0.05%
==========================================
Files 71 71
Lines 9305 9305
==========================================
+ Hits 5406 5411 +5
+ Misses 3352 3348 -4
+ Partials 547 546 -1
Continue to review full report at Codecov.
|
danielpacak
approved these changes
Apr 27, 2022
|
Thank you @SISheogorath working on this patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch adds the trivy mirror configuration to the starboard operator
helm chart. This particular implementation is made to match the
definitions from the documentation and therefore uses two layers for the
object and singular terminology.
The patch is required because currently there is no way than post
deployment patching of the configmap in order to utilise this feature,
which works against the intention of helm. It was also very confusing to
find the documentation providing this option, but the helm chart not
doing so, therefore this patch should help to cleanup potential
confusion.
References:
https://aquasecurity.github.io/starboard/v0.15.4/vulnerability-scanning/trivy/#settings
Checklist