Bug: metrics cmdline does not enable metrics

[rafaeldtinoco]

Description

After commit:

commit 0213c08
Author: Jose Donizetti jdbjunior@gmail.com
Date: Thu May 18 17:45:28 2023

tracee: add ready callback

The ready callback is executed once tracee is fully initialized,
and ready to receive events. This feature will be used for the
`/healthz` endpoint, which will only start to respond "OK" once
tracee is ready.

The following commandline:

$ sudo ./dist/tracee --metrics

Stopped registering prometheus stats. That happens because the prometheus metrics are registered at the end of Tracee.New() but it will fail because it depends on t.config.metricsEnabled which is enabled by the new introduced callback IF Server.metricsendpoint is also enabled (and it is only enabled after Tracee.New() is called).

I already have a patch that fixes this, will propose a PR (checking if tracee-rules metrics are being enabled).

Observations

This also brakes the make -f builder/Makefile.performance pyroscope-start dashboard (observed by Geyslan). So I'm checking what needs fixing (will need perf studies for event definitions).