fix(server): re-enable prometheus counters. #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and prometheus counters are working again. 👍🏼 I'll redo the panels created in #3297 on top of this working PR and raise the dashboard related one.
|
|
|
Im adding an integration test to test if metrics are enabled and this will be ready. |
rafaeldtinoco
force-pushed
the
perf-fixes
branch
from
5972cfc
to
4fb428a
Compare
rafaeldtinoco
force-pushed
the
perf-fixes
branch
from
706816e
to
922a5c4
Compare
|
So, if the "test-performance" target does not run (it has a skip if the user can't execute anything using "sudo -n" (with no password)) then I'll have to run the performance tests in a jenkins runner or change the runner config a bit. Lets see.
Test passes in regular github runner. It starts tracee using sudo and makes sure it ends at the end of the test as you can see in the code. |
- create testutils/tracee to start/stop tracee using sudo - test if --healthz works - test if --metrics works - test if --pprof works
- test if metrics are enabled on each PR
This brings two new panels to the dashboard: - Heap - GC And makes some minor changes to the existing panels.
rafaeldtinoco
force-pushed
the
perf-fixes
branch
from
5545f3f
to
f9baadd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit: 0213c08 ("tracee: add ready callback") made prometheus stats to stop being registered due to a timing issue. This patch re-enables it by registering prometheus counters in the callback function itself instead of in Tracee.New() (too early).
Fixes: #3303