-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make logger a standalone package #2600
Conversation
@@ -101,3 +103,5 @@ require ( | |||
) | |||
|
|||
replace github.com/kubernetes/cri-api => k8s.io/cri-api v0.23.5-rc.0 | |||
|
|||
replace github.com/aquasecurity/tracee/logger => ./logger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be removed after merge and go get
.
870eef8
to
992c609
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after a rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've discussed with @geyslan that a solution with a logger interface on libbpfgo's side should be attempted before going with the go.mod solution for these reasons (IMO):
- There are other consumers of libbpfgo besides us. Tying them to our logger from tracee isn't very ok from our end IMO, and I believe it's likely they would set their own logger for libbpfgo if possible (an interface solution would enable that).
- This would practically introduce a circular dependency of tracee -> libbpfgo -> tracee logger, where they are not circular only technically by the go.mod. The logger we have in tracee is very much intended for tracee's own particular uses (the log aggregation for example).
- Having another go.mod will make development more burdensome whenever we do a change to the logger, as we all know the
types
module already does. In addition any change in our logger would indirectly affect libbfpgo and may cause unintended behavior.
+1
+1
+1 |
As @NDStrahilevitz illuminatingly explained and I agreed, closing this. |
Initial Checklist
Description (git log)
commit 992c609
Necessary for:
Type of change
How Has This Been Tested?