fix(filters): handle syscall arg #3893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geyslan
force-pushed
the
the-one-with-syscall-arg-filter
branch
from
a9a3f53
to
3115934
Compare
There was a problem hiding this comment.
As this is a specific case, can we add a test? https://github.com/aquasecurity/tracee/blob/main/pkg/filters/args_test.go
geyslan
force-pushed
the
the-one-with-syscall-arg-filter
branch
from
0c1b76b
to
3d57ddd
Compare
NDStrahilevitz
previously requested changes
Feb 25, 2024
AlonZivony
reviewed
Feb 29, 2024
geyslan
force-pushed
the
the-one-with-syscall-arg-filter
branch
2 times, most recently
from
8148632
to
8995e8d
Compare
This comment was marked as spam.
This comment was marked as spam.
geyslan
force-pushed
the
the-one-with-syscall-arg-filter
branch
from
8995e8d
to
4180c90
Compare
Handle syscall arg either by its name or its number for the events SysEnter and SysExit. E.g.: - sys_enter.args.syscall=open - sys_enter.args.syscall=2 It uses a handler function to be passed to the filter constructor. This also adds unit tests for Filter().
geyslan
force-pushed
the
the-one-with-syscall-arg-filter
branch
from
4180c90
to
d8035bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #3891
1. Explain what the PR does
8995e8d fix(filters): handle syscall arg
2. Explain how to test it
sudo ./dist/tracee -e sys_enter.args.syscall=bpfTrigger some bpf syscall.
3. Other comments