Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: split commands to download db for different versions of oras #2582

Merged
merged 3 commits into from
Jul 25, 2022

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Jul 25, 2022

Description

In oras v0.13.0 the -a/--allow-all behavior is set by default and these flags have been removed(oras-project/oras#387).
Also grouping code blocks was used:
e.g.:

Снимок экрана от 2022-07-25 17-56-33

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Comment on lines 12 to 16
```
$ oras pull ghcr.io/aquasecurity/trivy-db:2
```

for `oras` v0.12.0 or earlier, `-a` flag must be used:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use "grouping code blocks"?
https://squidfunk.github.io/mkdocs-material/reference/content-tabs/#linked-content-tabs

Suggested change
```
$ oras pull ghcr.io/aquasecurity/trivy-db:2
```
for `oras` v0.12.0 or earlier, `-a` flag must be used:
=== oras >= v0.13.0
```
$ oras pull ghcr.io/aquasecurity/trivy-db:2
```
=== oras < v0.13.0
```
$ oras pull -a ghcr.io/aquasecurity/trivy-db:2
```

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@knqyf263 knqyf263 merged commit 5f9a963 into main Jul 25, 2022
@knqyf263 knqyf263 deleted the docs/oras-a-flag branch July 25, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offline use documentation includes obsolete flag to oras
2 participants