-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump github.com/CycloneDX/cyclonedx-go from 0.6.0 to 0.7.0 #2974
Merged
knqyf263
merged 8 commits into
main
from
dependabot/go_modules/github.com/CycloneDX/cyclonedx-go-0.7.0
Jan 3, 2023
Merged
chore(deps): bump github.com/CycloneDX/cyclonedx-go from 0.6.0 to 0.7.0 #2974
knqyf263
merged 8 commits into
main
from
dependabot/go_modules/github.com/CycloneDX/cyclonedx-go-0.7.0
Jan 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/CycloneDX/cyclonedx-go](https://github.com/CycloneDX/cyclonedx-go) from 0.6.0 to 0.7.0. - [Release notes](https://github.com/CycloneDX/cyclonedx-go/releases) - [Changelog](https://github.com/CycloneDX/cyclonedx-go/blob/master/.goreleaser.yml) - [Commits](CycloneDX/cyclonedx-go@v0.6.0...v0.7.0) --- updated-dependencies: - dependency-name: github.com/CycloneDX/cyclonedx-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
knqyf263
reviewed
Oct 12, 2022
pkg/sbom/cyclonedx/unmarshal.go
Outdated
@@ -104,7 +104,7 @@ func (c *CycloneDX) UnmarshalJSON(b []byte) error { | |||
// Keep the original SBOM | |||
c.CycloneDX = &ftypes.CycloneDX{ | |||
BOMFormat: bom.BOMFormat, | |||
SpecVersion: bom.SpecVersion, | |||
SpecVersion: strconv.Itoa(int(bom.SpecVersion)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should convert SpecVersion
.
https://github.com/CycloneDX/cyclonedx-go/blob/39a1d8f8f69040a53114e1ea481e48f6d792c05e/cyclonedx.go#L470-L478
This PR is stale because it has been labeled with inactivity. |
github-actions
bot
added
the
lifecycle/stale
Denotes an issue or PR has remained open with no activity and will be auto-closed.
label
Dec 12, 2022
github-actions
bot
removed
the
lifecycle/stale
Denotes an issue or PR has remained open with no activity and will be auto-closed.
label
Dec 22, 2022
knqyf263
approved these changes
Jan 3, 2023
knqyf263
deleted the
dependabot/go_modules/github.com/CycloneDX/cyclonedx-go-0.7.0
branch
January 3, 2023 13:15
umax
pushed a commit
to umax/trivy
that referenced
this pull request
Jan 4, 2023
….0 (aquasecurity#2974) Co-authored-by: DmitriyLewen <dmitriy.lewen@smartforce.io> Co-authored-by: masahiro331 <m_fujimura@r.recruit.co.jp>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/CycloneDX/cyclonedx-go from 0.6.0 to 0.7.0.
Release notes
Sourced from github.com/CycloneDX/cyclonedx-go's releases.
Commits
39a1d8f
Merge pull request #57 from CycloneDX/tweaks124f2be
docs: fix typos8f8fadf
docs: fix cyclonedx-go version in compatibility matrix7415143
feat: return error when parsing unknown spec versionsc2db05e
Merge pull request #56 from CycloneDX/issue-36ea0d5b7
fix: prevent nesting ofDependency
3390ca4
Merge pull request #55 from CycloneDX/refine-conversionacb9322
feat: add enum for official media types1655b7d
feat: setSpecVersion
when decoding from xml5f10aea
refactor: refine spec version conversion to cover more casesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)