feat(image): add support for passing architecture and OS #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Oct 13, 2022
| @@ -35,6 +35,195 @@ Total: 1 (UNKNOWN: 0, LOW: 0, MEDIUM: 1, HIGH: 0, CRITICAL: 0) | |||
|
|
|||
| </details> | |||
|
|
|||
| ### Scan the image on a specific Architecture and OS | |||
There was a problem hiding this comment.
pkg/commands/app.go
Outdated
Comment on lines
237
to
239
| # Scan a container image on a specific architecture and os | ||
| $ trivy image --platform=arm/linux python:3.4-alpine | ||
|
|
There was a problem hiding this comment.
Thanks for adding, but we can remove the example. I'd like to list here only the frequently used flags.
pkg/fanal/image/remote.go
Outdated
| @@ -25,6 +26,17 @@ func tryRemote(ctx context.Context, imageName string, ref name.Reference, option | |||
| remoteOpts = append(remoteOpts, remote.WithTransport(t)) | |||
| } | |||
|
|
|||
| if option.Platform != "" { | |||
| platform := strings.Split(option.Platform, "/") | |||
There was a problem hiding this comment.
|
@knqyf263 Thank you for your feedback! Made the required and necessary changes! Please take a look :)) |
knqyf263
approved these changes
Oct 25, 2022
|
Thanks for your great contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for passing an architecture and OS to the image command:
They can be used as:
Pass a
--platformargument with a valid architecture and OS combination on the remote image:Example:
This PR also introduces the tests for the same in image_test.go
Related issues
Checklist