Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(image): extend image config analyzer #3434

Merged
merged 4 commits into from
Jan 16, 2023
Merged

refactor(image): extend image config analyzer #3434

merged 4 commits into from
Jan 16, 2023

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Jan 15, 2023 •
edited
Loading

Description

We're planning to migrate Dockle into Trivy. It detects misconfiguration in container image config. This PR extends the image config analyzer interface for the subsequent PRs.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Jan 15, 2023
@knqyf263 knqyf263 changed the title refactor(image): extend config analyzer refactor(image): extend image config analyzer Jan 15, 2023
@knqyf263 knqyf263 marked this pull request as ready for review January 15, 2023 20:48
DmitriyLewen
DmitriyLewen reviewed Jan 16, 2023
View reviewed changes
pkg/fanal/artifact/image/image.go Outdated Show resolved Hide resolved
pkg/fanal/analyzer/command/apk/apk_test.go Outdated Show resolved Hide resolved
@knqyf263 knqyf263 merged commit c575d6f into aquasecurity:main Jan 16, 2023
@knqyf263 knqyf263 deleted the config_analyzer branch January 16, 2023 11:48
@knqyf263 knqyf263 mentioned this pull request Jan 16, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knqyf263 @DmitriyLewen