Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): use trivy-java-db to get GAV #3484

Merged
merged 17 commits into from
Feb 1, 2023

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Jan 26, 2023

Description

Use trivy-java-db to get GAV

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Jan 30, 2023
@dheeg
Copy link

dheeg commented Jan 31, 2023

@DmitriyLewen Would it be possible to download the Java DB as well, if the already present parameter --download-db-only is used? We use this parameter to build a daily image and therefor to only download once, but execute thousands of times.

@DmitriyLewen DmitriyLewen marked this pull request as ready for review February 1, 2023 04:17
@DmitriyLewen
Copy link
Contributor Author

DmitriyLewen commented Feb 1, 2023

Hello @dheeg
Thanks! it is good idea.

We add download-java-db-only flag.

@knqyf263 knqyf263 merged commit 7bf1e19 into aquasecurity:main Feb 1, 2023
@cpach
Copy link
Contributor

cpach commented Feb 1, 2023

This is awesome. Great job @knqyf263 and @DmitriyLewen! Are you planning on making a Trivy release soon?

@knqyf263
Copy link
Collaborator

knqyf263 commented Feb 1, 2023

It's out now.
#3518

@knqyf263
Copy link
Collaborator

knqyf263 commented Feb 1, 2023

v0.37.0 has a critical issue. Please try v0.37.1.

@DmitriyLewen DmitriyLewen deleted the feat/trivy-java-db branch September 29, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Java database to eliminate dependency on external APIs trivy image scan suddenly timing out
4 participants