Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vuln): Document inline vulnerability filtering comments #4024

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

jof
Copy link
Contributor

@jof jof commented Apr 10, 2023

Description

Document inline vulnerability filtering comments. I use and love this feature, and couldn't find it in the docs, so here is a little blurb about it.

Related issues

Checklist

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2023

CLA assistant check
All committers have signed the CLA.

@itaysk
Copy link
Contributor

itaysk commented Apr 11, 2023

@AnaisUrlichs can you PTAL?

@jof jof force-pushed the jof/inline-filtering branch 2 times, most recently from 4ea058f to 1d99fa9 Compare April 11, 2023 23:45
@knqyf263
Copy link
Collaborator

Hi @jof, we recently restructured the document so that options can be in a single place. Could you update this PR accordingly?
https://github.com/aquasecurity/trivy/blob/57bb77c060afcf93e7952867af5922783dc1e55e/docs/docs/configuration/filtering.md

@jof
Copy link
Contributor Author

jof commented Apr 17, 2023

A git rebase delightfully moved my patch to the renamed file. Updated.

@knqyf263
Copy link
Collaborator

A git rebase delightfully moved my patch to the renamed file. Updated.

Smart! Thanks for updating.

I've added a table as this filtering is dedicated to misconfiguration.
07bb6e5

@knqyf263 knqyf263 merged commit 572a619 into aquasecurity:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trivy should document all of the Vulnerability Filtering options, including inline comments
4 participants