Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PURL matching with qualifiers in OpenVEX #5061

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

knqyf263
Copy link
Collaborator

Description

Trivy supports the exact match for PURL and BOM-Ref in OpenVEX.
https://aquasecurity.github.io/trivy/v0.44/docs/supply-chain/vex/#openvex

This PR uses PURL matching with qualifiers, as discussed here. Also, it bumps the OpenVEX spec to v0.2.0, including some breaking changes.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Aug 29, 2023
@knqyf263 knqyf263 marked this pull request as ready for review August 29, 2023 12:16
docs/docs/supply-chain/vex.md Outdated Show resolved Hide resolved
}
return true
// Take the effective statement
stmt := stmts[len(stmts)-1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify why we need get only last matched element?

If i understand correctly if we swap statements in example - we will not filter CVE-2021-44228.
But i am not sure that we need filter this CVE in this case.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added abb7295

knqyf263 and others added 2 commits August 30, 2023 10:09
Co-authored-by: DmitriyLewen <91113035+DmitriyLewen@users.noreply.github.com>
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 added this pull request to the merge queue Aug 30, 2023
Merged via the queue into aquasecurity:main with commit 49fdd58 Aug 30, 2023
17 checks passed
@knqyf263 knqyf263 deleted the feat/vex_purl branch August 30, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PURL in OpenVEX
2 participants