Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vex): add PURL matching for CSAF VEX #5890

Merged
merged 5 commits into from
Jan 10, 2024
Merged

feat(vex): add PURL matching for CSAF VEX #5890

merged 5 commits into from
Jan 10, 2024

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Jan 8, 2024

Description

Add PURL matching similar to #5061 for CSAF VEX.

In addition, PkgIdentifier.PURL is replaced from purl.PackageURL with packageurl.PackageURL for better packaging.

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263
refactor(types): replace with packageurl.PackageURL
dbd8447 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263
feat(vex): add PURL matching
528413c 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 self-assigned this Jan 8, 2024
@knqyf263
fix: lint issues
b5c2a1f 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263
fix: nil handling
0dbc7c2 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263
fix: replace empty slice with nil
3afb74b 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 changed the title feat(vex): add PURL matching feat(vex): add PURL matching for CSAF VEX Jan 8, 2024
@knqyf263 knqyf263 marked this pull request as ready for review January 8, 2024 17:31
DmitriyLewen
DmitriyLewen approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 added this pull request to the merge queue Jan 10, 2024
Merged via the queue into aquasecurity:main with commit d0c81e2 Jan 10, 2024
13 checks passed
@knqyf263 knqyf263 deleted the purl_match branch January 10, 2024 06:57
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

@chen-keinan chen-keinan Awaiting requested review from chen-keinan chen-keinan is a code owner

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knqyf263 @DmitriyLewen