-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add code coverage #572
Conversation
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
=========================================
Coverage ? 55.68%
=========================================
Files ? 44
Lines ? 2085
Branches ? 0
=========================================
Hits ? 1161
Misses ? 803
Partials ? 121 Continue to review full report at Codecov.
|
Thanks! Does Codecov affect the test result? For example, it fails the test if the coverage is reduced. It's OK If it's not the case. In my experience, the coverage is useful, but it doesn't need to affect the test result. |
043b19e
to
fc3a8c6
Compare
Signed-off-by: Simarpreet Singh <simar@linux.com>
We can run it in informational mode where the PR is not gated (failed) if the coverage is lower than what it was before. See more https://docs.codecov.io/docs/commit-status#branches I've changed it to behave like that now. Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Would it make sense to run codecov over other Trivy repos e.g. fanal? |
Yes, we should add codecov in fanal and trivy-db as well. |
Signed-off-by: Simarpreet Singh <simar@linux.com>
This adds code coverage to each PR we create.
Addresses: #563
Signed-off-by: Simarpreet Singh simar@linux.com