Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison table to use words instead of symbols #587

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

rndmh3ro
Copy link
Contributor

@rndmh3ro rndmh3ro commented Aug 4, 2020

fixes #301

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #587 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   55.84%   55.84%           
=======================================
  Files          44       44           
  Lines        2113     2113           
=======================================
  Hits         1180     1180           
  Misses        810      810           
  Partials      123      123           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52feff2...0ece24e. Read the comment docs.

Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good @rndmh3ro@knqyf263 would you know if the entries we have here are still up to date for the other projects?

@knqyf263
Copy link
Collaborator

knqyf263 commented Aug 5, 2020

This data is as of May 2019. I'm not sure about the current status of the other projects. We can remove this table.

@knqyf263 knqyf263 merged commit 9a25f4f into aquasecurity:master Aug 5, 2020
@knqyf263
Copy link
Collaborator

knqyf263 commented Aug 5, 2020

I merged this PR once, but let's consider if we should keep this table.

@rndmh3ro rndmh3ro deleted the patch-1 branch August 5, 2020 07:39
@AkihiroSuda
Copy link

This conversion doesn't seem correct.
△ means "Not so bad, but not good either".
It never means "Good".

@knqyf263
Copy link
Collaborator

knqyf263 commented Sep 2, 2020

@AkihiroSuda You're right, but I couldn't come up with a good short phrase. Can we say "not bad"?

@AkihiroSuda
Copy link

sgtm

@knqyf263
Copy link
Collaborator

knqyf263 commented Sep 2, 2020

Thanks. I fixed it. #623

liamg pushed a commit that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Legend in Readme for Comparison with other scanners
5 participants