Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update comparison table #623

Merged
merged 2 commits into from Sep 2, 2020
Merged

chore(docs): update comparison table #623

merged 2 commits into from Sep 2, 2020

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Sep 2, 2020

Changes

  • Convert "Good" to "Not bad" (we converted △ to "Good" for clarification, but I originally meant "not so good, not so bad".)
  • Remove MicroScanner
  • Convert "Not present" to "Not good" in DockerHub

Issue

#587 (comment)

@knqyf263 knqyf263 self-assigned this Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #623 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #623   +/-   ##
=======================================
  Coverage   54.84%   54.84%           
=======================================
  Files          48       48           
  Lines        2299     2299           
=======================================
  Hits         1261     1261           
  Misses        908      908           
  Partials      130      130           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8b0962...074c17a. Read the comment docs.

@knqyf263 knqyf263 changed the title chore(docs): update README chore(docs): update comparison table Sep 2, 2020
@AkihiroSuda
Copy link

LGTM

Another way might be using star symbols:

  • ◎ → ⭐ ⭐ ⭐ ⭐
  • ○ → ⭐ ⭐ ⭐
  • △ → ⭐ ⭐
  • × → ⭐

@knqyf263
Copy link
Collaborator Author

knqyf263 commented Sep 2, 2020

It sounds nice. What do you think, @lizrice?

@lizrice
Copy link
Contributor

lizrice commented Sep 2, 2020

Yes, there are definitely some issues with the wording currently. "Good" means better than "OK", but I'm not sure that's what is intended in this table? And "not good" and "not bad" are very ambiguous terms (it's unclear whether they are better or worse than "OK"!)

I think that for the first two columns, OS packages and App dependencies, it's a yes/no question of whether they are supported or not? In which case how about

  • supported →✅
  • not supported → ×

And then for the other three columns, I'd suggest

  • ◎ (best) → ⭐ ⭐ ⭐
  • ○ → ⭐ ⭐
  • △ → ⭐
  • × (not supported) → ×

@knqyf263
Copy link
Collaborator Author

knqyf263 commented Sep 2, 2020

@lizrice Thanks. I've updated it.

Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@knqyf263 knqyf263 merged commit 2231e40 into master Sep 2, 2020
@knqyf263 knqyf263 deleted the fix/table branch September 2, 2020 13:56
liamg pushed a commit that referenced this pull request Jun 7, 2022
* chore(docs): update README

* use ⭐
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants