ci(deps): fix tenv in ".*_test.go$" #6746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
requested review from
simar7,
nikpivkin,
knqyf263 and
DmitriyLewen
as code owners
mmorel-35
commented
May 22, 2024
| @@ -87,7 +87,7 @@ func Test_evaluateVariable(t *testing.T) { | |||
| } | |||
|
|
|||
| envName := "TEST_GO_DEP_PARSER" | |||
| os.Setenv(envName, "1.2.3") | |||
| t.Setenv(envName, "1.2.3") | |||
| defer os.Unsetenv(envName) | |||
There was a problem hiding this comment.
I'm wondering if it is still usefull with t.SetEnv being used.
There was a problem hiding this comment.
Indeed, it's already handle https://cs.opensource.google/go/go/+/refs/tags/go1.22.3:src/testing/testing.go;l=1298
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes tenv linter issues in ".*_test.go$"