Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSR-12: Extended Coding Style #19

Closed
arcostasi opened this issue Aug 12, 2019 · 4 comments
Closed

PSR-12: Extended Coding Style #19

arcostasi opened this issue Aug 12, 2019 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@arcostasi
Copy link
Member

Add new PSR-12 changes to php_cs.dist
@arcostasi arcostasi added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 12, 2019
@vinyvicente
Copy link
Contributor

needs await php-cs-fixer implements PSR-12.

@arcostasi arcostasi assigned arcostasi and unassigned arcostasi Aug 12, 2019
@vinyvicente
Copy link
Contributor

Keep in mind: PHP-CS-Fixer/PHP-CS-Fixer#4502

@peter279k
Copy link
Member

@arcostasi, just note that the PHP_CodeSniffer has already supported for PSR-12 coding style.

And it can use vendor/bin/phpcs --standard=psr12 src tests.

But never mind, we can still wait for FriendsOfPHP/PHP-CS-Fixer#4502 :).

@arcostasi
Copy link
Member Author

Thanks @peter279k, added support for PSR-12 coding style.

Added PSR-12 Extended Coding Style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vinyvicente @arcostasi @peter279k