Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example not working with torch 0.4.1 #16

Closed
madjokal opened this issue Sep 25, 2018 · 4 comments
Closed

Example not working with torch 0.4.1 #16

madjokal opened this issue Sep 25, 2018 · 4 comments

Comments

@madjokal
Copy link

Using an anaconda environment with pytorch 0.4.1 I tried to run the example provided on README. On

y = (1 - 2 * math.pi**2 * freq**2 * t**2) * torch.exp(-math.pi**2 * freq**2 * t**2)

I get the error:

RuntimeError: "exp" not implemented for 'torch.LongTensor'
@ar4
Copy link
Owner

ar4 commented Sep 25, 2018

Hi @madjokal and thank you for filing your first issue. This was fixed in the master branch when 0.4.1 was released. I have not yet made a new release since then, however. To install the master branch rather than the release, you should be able to use pip install git+https://github.com/ar4/deepwave.git. It is possible that the example in the README, and the example notebook, might be outdated compared to the master branch code. I will make a new release in a few days, at which point I will try to make sure everything is coherent.

@ar4 ar4 closed this as completed Sep 25, 2018
@ar4
Copy link
Owner

ar4 commented Sep 25, 2018

I have updated the README, but the linked notebook has not been updated yet. If you are able to try the master branch code, it would be helpful if you reported back whether it works well for you.

@madjokal
Copy link
Author

Yeah, the current example is working now. Thanks!

@ar4
Copy link
Owner

ar4 commented Sep 26, 2018

That's great. I have also just updated the notebook (quite extensively - it now also demonstrates other features such as source inversion and chaining operations), and made a new release v0.0.2. Please let me know if you have any more issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants