Add source-maps for better stack traces #403
Conversation
| @@ -71,6 +73,7 @@ | |||
| "opn": "^5.3.0", | |||
| "rimraf": "^2.6.2", | |||
| "semver": "^5.4.1", | |||
| "source-map-support": "^0.5.11", | |||
There was a problem hiding this comment.
I've tried using @babel/register instead, but it uses relative paths which my editor cannot open...:
> TypeError: Cannot read property 'links' of undefined
at console (../../src/commands/ipfs_propagate.js:37:11)
Note: @babel/register uses source-map-support under the hood.
packages/aragon-cli/package.json
Outdated
| @@ -8,11 +8,13 @@ | |||
| "dao": "./aliases/dao" | |||
| }, | |||
| "scripts": { | |||
| "build": "npm run extract-roles && babel -d dist src --copy-files", | |||
| "build": "npm run extract-roles && npm run compile:src", | |||
| "watch": "npm run build -- -- --watch", | |||
There was a problem hiding this comment.
| "watch": "npm run build -- -- --watch", | |
| "start": "npm run build -- -- --watch", |
There was a problem hiding this comment.
I think start feels kind of weird, since you're not technically starting anything (you'd still need to link it?). What about build:watch?
There was a problem hiding this comment.
Makes sense. Would be awesome if we could come up with a "community standard" like:
npm start - for production use (build, link, etc.)
npm run dev - for dev use
So you only one command (besides install) to get up and running, without looking in package.json.
Would've been cool if the npm team "reserved" a script for this. :D
Before:
After: