Add deploy event compatibility #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xGabi
approved these changes
Sep 20, 2019
sohkai
reviewed
Oct 15, 2019
| events[exports.OLD_BARE_TEMPLATE_DEPLOY_EVENT] | ||
| events[exports.OLD_BARE_TEMPLATE_DEPLOY_EVENT] || | ||
| // Some templates use DeployDAO instead of DeployDao | ||
| events['DeployDAO'] |
There was a problem hiding this comment.
🤦♂ are these the old kits?
There was a problem hiding this comment.
The problem was in the boilerplate: https://github.com/aragon/aragon-react-boilerplate/blob/558074e1863bbcb44cb0d2c6470866bbd94ca40e/contracts/Template.sol#L30
But it seems to be fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦅 Pull Request
Some templates use
DeployDAOevents instead ofDeployDao. This PR adds support for those events.🚨 Test instructions
✔️ PR Todo