Split sumtree #39
Closed
Split sumtree #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingen
commented
May 15, 2019
added 8 commits
May 16, 2019 19:15
Add tests for batches.
added 8 commits
May 17, 2019 10:09
Simplify activation/deactivation logic. Address PR #41 comments.
and that it does from the very beginning. Address PR #41 comments.
Before if all jurors returned by sortition (could be just one, so not so unlikely) are overleveraged (and therefore discarded), calling again sortition function would return the same result, so jurors would be discarded again, resulting in an infinite loop (out of gas error). Address PR #41 comments.
It's fixed here: aragon/aragonOS#522 (Until it's released `npm link @aragon/os is needed for coverage`)
added 4 commits
May 23, 2019 19:28
Needed for settleAppealDeposit in PR #40.
added 17 commits
May 31, 2019 10:34
Closes #48.
In case not all batches were fullfilled. Closes issue #14.
With batching, it doesn't make sense, as it could run out of gas. It must be done manually before.
Court: allow to continue draft at a later term
Court: remove dismiss dispute
Drafting will have to wait for a later term where randomness seed is available. Closes #15.
Address PR #41 comments.
Address PR #58 comments.
Court: prevents drafting without randomness seed
Plus make _getVoteId and _decodeVoteId pure. Missing changes in commit d4234fc: "Court: build voteId from disputeId and roundId".
|
Closing this PR since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
TODO: