Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split sumtree #39

Closed
wants to merge 43 commits into from
Closed

Split sumtree #39

wants to merge 43 commits into from

Conversation

@bingen
Copy link
Member

bingen commented May 14, 2019

Closes #8

TODO:

  • Protect HexSumTreeWrapper so only owner (Court) can alter the tree
@bingen bingen requested a review from izqui May 14, 2019
@bingen bingen self-assigned this May 14, 2019
@bingen bingen force-pushed the split_sumtree branch from bf26b17 to 350127b May 14, 2019
@bingen bingen changed the base branch from split_voting to multiSortition May 15, 2019
@bingen bingen changed the base branch from multiSortition to split_voting May 15, 2019
@bingen bingen force-pushed the split_sumtree branch from bd0932f to 7dc3472 May 16, 2019
@bingen bingen force-pushed the split_sumtree branch from 7dc3472 to d3615ab May 16, 2019
bingen added 8 commits May 17, 2019
Simplify activation/deactivation logic.
Address PR #41 comments.
and that it does from the very beginning.

Address PR #41 comments.
Before if all jurors returned by sortition (could be just one, so not
so unlikely) are overleveraged (and therefore discarded), calling
again sortition function would return the same result, so jurors would
be discarded again, resulting in an infinite loop (out of gas error).

Address PR #41 comments.
It's fixed here: aragon/aragonOS#522
(Until it's released `npm link @aragon/os is needed for coverage`)
@bingen bingen force-pushed the split_sumtree branch from 7fb1673 to f93916f May 22, 2019
@bingen bingen force-pushed the split_sumtree branch from a3c9f18 to 66bf9ff May 22, 2019
@bingen bingen force-pushed the split_sumtree branch from 66bf9ff to 3d490a1 May 23, 2019
bingen added 17 commits May 24, 2019
Closes #48.
In case not all batches were fullfilled.
Closes issue #14.
With batching, it doesn't make sense, as it could run out of gas. It
must be done manually before.
Court: allow to continue draft at a later term
Court: remove dismiss dispute
Drafting will have to wait for a later term where randomness seed is
available.

Closes #15.
Address PR #41 comments.
Address PR #58 comments.
Court: prevents drafting without randomness seed
Plus make _getVoteId and _decodeVoteId pure.

Missing changes in commit d4234fc: "Court: build voteId from disputeId
and roundId".
@facuspagnuolo

This comment has been minimized.

Copy link
Member

facuspagnuolo commented Aug 1, 2019

Closing this PR since development branch was already updated with these commits manually

@facuspagnuolo facuspagnuolo deleted the split_sumtree branch Aug 1, 2019
@izqui izqui added this to the Freeze #1 milestone Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.