Adapt frontend app to the same style as other aragon apps #10
Conversation
Use babel. USe SafeMath for contract.
bingen
changed the title
.gitignore
Outdated
| dist | ||
| package-lock.json |
There was a problem hiding this comment.
This probably shouldn't be part of the .gitignore, as users (of the cloned repo) might want to check it in.
There was a problem hiding this comment.
Besides, it seems that it's used for IPFS too, so I should remove then dist too: https://github.com/aragon/aragon-cli/blob/master/src/commands/apm_cmds/publish.js#L102
I'll try to think of a better solution.
app/App.js
Outdated
| return ( | ||
| <AppContainer> | ||
| <div> | ||
| <ObservedCount observable={this.state.state$} /> | ||
| <ObservedCount observable={this.state.observable} /> |
There was a problem hiding this comment.
Should be this.props.observable
app/main.js
Outdated
| componentWillUnmount() { | ||
| window.removeEventListener('message', this.handleWrapperMessage) | ||
| } | ||
| handleWrapperMessage = ({ data }) => { |
There was a problem hiding this comment.
Let's add a comment here to explain that this is for a handshake between Aragon Core and the iframe, since iframes can lose messages that were sent before they were ready.
Address PR #10 comments. It needs aragon/aragon-cli#111
bingen
changed the title
| case 'Decrement': | ||
| return { count: parseInt(state.count, 10) - parseInt(event.returnValues.step, 10) } | ||
| return { count: await getValue() } |
There was a problem hiding this comment.
I guess you could get rid of the switch, or at least join those 2 cases.
There was a problem hiding this comment.
Wanted to keep the switch so it was obvious what the pattern would be for a more complicated app :).
Use babel.
Use SafeMath for contract.