Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to handle external transaction intents #120

Closed
sohkai opened this issue Jun 5, 2018 · 2 comments · Fixed by #328
Closed

Add ability to handle external transaction intents #120

sohkai opened this issue Jun 5, 2018 · 2 comments · Fixed by #328
Labels
enhancement New feature or request

Comments

@sohkai
Copy link
Contributor

sohkai commented Jun 5, 2018

It would be interesting to let a frontend create transactions for external contracts (and not just the app's listed contract) in cases where an app needs to communicate to multiple contracts (e.g. in patterns where the initial app contract is a factory for a few other contracts).

The built transaction should probably still go through the transactions observable, and any frontends should display them with slightly different information (e.g. "This will send a transaction to an external contract at 0x...")

@sohkai sohkai added enhancement New feature or request component: apps labels Jun 12, 2018
@sohkai
Copy link
Contributor Author

sohkai commented Jun 12, 2018

From #43:

In the case of sending transactions, it should be handled differently than current 'intents' and allow to perform the action directly without calculating any fwd path. The signer in the wrapper should let the user know it is not a 'normal action' being performed and it could have consequences. In the case of known actions such as token transfers, we would be able to provide a description for it.

@stale
Copy link

stale bot commented Jun 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for contributing to Aragon! 🦅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants