Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent issue trying to access repo artifacts from aragonCLI #325

Closed
0xGabi opened this issue Jun 15, 2019 · 6 comments
Closed

Intermittent issue trying to access repo artifacts from aragonCLI #325

0xGabi opened this issue Jun 15, 2019 · 6 comments
Labels
bug Something isn't working

Comments

@0xGabi
Copy link
Contributor

0xGabi commented Jun 15, 2019

This particular issue happens both when trying to publish with aragon apm publish and executing a function with dao exec. It is happening randomly so that makes me think it depends on the time it take to complete the task.

The error output is: Could not create transaction due to missing app artifact

The issue was introduce after wrapper-5.0.0-rc.9. I believe this commit in particular: 0caae25

I tried changing the time argument but it was not helpful. Only once I got a different error instead: No ABI specified in artifact for..

We currently pin version rc9 until we can figure out a solution.

@sohkai
Copy link
Contributor

sohkai commented Jul 3, 2019

Interesting, it definitely shouldn't be that commit.

If it's an app artifact that's missing, it's likely something to do with the IPFS timeout? Perhaps we're not passing in the timeouts specified from the CLI correctly into aragon.js?

@sohkai sohkai added the bug Something isn't working label Jul 3, 2019
@0xGabi
Copy link
Contributor Author

0xGabi commented Jul 12, 2019

@sohkai I tested with last changes (after pass apm.ipfs option to wrapper) and the issue is still present. As you mention we might need to specify a timeout (DEFAULT_IPFS_TIMEOUT on aragonCLI). For what I understand we need to provide the timeout to apm in this line of the wrapper?

@sohkai
Copy link
Contributor

sohkai commented Jul 13, 2019

Hmm, yes, it would be, although I've been thinking we should just take out apm.js from aragon.js since the it's very easy to replicate the parts it needs (and it would make it easier to pass this option along too).

@kernelwhisperer
Copy link
Contributor

Hmm, yes, it would be, although I've been thinking we should just take out apm.js from aragon.js since the it's very easy to replicate the parts it needs (and it would make it easier to pass this option along too).

What do you mean by taking out apm.js from aragon.js ?

@sohkai
Copy link
Contributor

sohkai commented Jul 19, 2019

What do you mean by taking out apm.js from aragon.js ?

aragon.js currently uses apm.js for very trivial things, and apm.js adds a lot of bloat due to its "optional" ipfs-api dependency.

The few things aragon.js does need from apm.js, it has almost already re-implemented anyway (Repo support, ENS resolution), and I just need to do a bit more to finally remove apm.js from it.

@stale stale bot added the abandoned label Jan 15, 2020
@aragon aragon deleted a comment from stale bot Jan 15, 2020
@stale stale bot removed the abandoned label Jan 15, 2020
@sohkai
Copy link
Contributor

sohkai commented Mar 17, 2020

Does not appear to be an issue anymore; there is a remaining issue with aragon/aragon-cli#1082 but we'll keep tracking that in the aragonCLI repo.

@sohkai sohkai closed this as completed Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants