Custom labels #630
Closed
Custom labels #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AquiGorka
force-pushed
the
feature/custom-labels
branch
2 times, most recently
from
a89a660
to
03389a9
Compare
AquiGorka
force-pushed
the
feature/custom-labels
branch
2 times, most recently
from
8b91bea
to
0d10020
Compare
2 tasks
AquiGorka
force-pushed
the
feature/custom-labels
branch
5 times, most recently
from
4e34d37
to
708301b
Compare
6 tasks
AquiGorka
force-pushed
the
feature/custom-labels
branch
2 times, most recently
from
fe98d26
to
5870cc9
Compare
AquiGorka
force-pushed
the
feature/custom-labels
branch
from
5870cc9
to
f51e724
Compare
|
@AquiGorka I left only @sohkai and @bpierre as reviewers since they are the only ones required to review this PR |
AquiGorka
force-pushed
the
feature/custom-labels
branch
4 times, most recently
from
7bee92c
to
42c41bc
Compare
AquiGorka
force-pushed
the
feature/custom-labels
branch
from
fcf7bf1
to
0f2ee87
Compare
2color
reviewed
Mar 7, 2019
| @@ -37,10 +37,11 @@ | |||
| "lodash.uniqby": "^4.7.0", | |||
| "onecolor": "^3.0.5", | |||
| "prop-types": "^15.6.2", | |||
| "react": "^16.7.0", | |||
| "react": "^16.8.3", | |||
| "react-blockies": "^1.3.0", | |||
| "react-container-dimensions": "^1.3.3", | |||
| "react-dom": "^16.7.0", | |||
There was a problem hiding this comment.
I think react-dom also needs to be upgraded to to 16.8.x to utilise hook support. I got this error: https://reactjs.org/warnings/invalid-hook-call-warning.html.
There was a problem hiding this comment.
Shoot! You are correct. I'll wait till we merge your PR so no need to update here.
This was referenced Mar 20, 2019
Merged
|
Closing in favor of #656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes:
Videos (updated March 4th):
Mobile:
https://www.useloom.com/share/2cbf05eea7624abeb306a9cd86a406f2
Desktop:
https://www.useloom.com/share/a3bc58e6f76448b8ba21309986ea0fb0
aragon.jsis done).json.jsonaragon/aragonaragon/aragon#637aragon/aragon-apps