Renaming 'App' contract to 'AragonApp' #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing because you forgot to change it in the tests as well |
onbjerg
changed the title
|
Okay, I gonna try to fix the tests as well. |
Checked Travi-ci and fixed the problems being caused by "DeclarationError: Identifier not found or not unique." since 'App' was renamed in issue aragon#173 and it should be called 'AragonApp'.
|
Awesome, thanks for this! |
|
@izqui Just noting here that the next published version on npm should be at least 2.0.0 since this breaks every app 😊 |
|
Current version is 2.0.1, next is 3.0.0 :) |
|
Oh, sorry! 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #173